Fix argument parsing for vertex and face colors of mesh3d traces #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small typo in the argument parsing for mesh3d types. The
vertexcolor
andfacecolor
arguments were accidentally capitalized in some of the files. This switches them to be consistent with the lower case form in thedefaults
andattributes
files.I also added a test case to the dashboard verify that the colors are indeed getting parsed correctly. Here is an image:
To verify that it works, go in the gl3d dashboard and open up the example "Tetrahedra". Once this works then we can do
trisurf
with face colors, just like MATLAB.CC @etpinard